浏览代码

fix(jira): Make prefix check on "jira branch" command case-insensitive (#8799)

* Make prefix check on "jira branch" command case-insensitive

* Update plugins/jira/jira.plugin.zsh

Co-authored-by: Marc Cornellà <hello@mcornella.com>

* Fixing tabs to spaces

Co-authored-by: Robby Russell <robby@planetargon.com>
Co-authored-by: Marc Cornellà <hello@mcornella.com>
Alex 2 年之前
父节点
当前提交
9f31951019
共有 2 个文件被更改,包括 6 次插入1 次删除
  1. 5 0
      plugins/jira/README.md
  2. 1 1
      plugins/jira/jira.plugin.zsh

+ 5 - 0
plugins/jira/README.md

@@ -27,6 +27,11 @@ jira branch     # opens an existing issue matching the current branch name
                 # The branch name may have prefixes ending in "/": "feature/MP-1234",
                 # and also suffixes starting with "_": "MP-1234_fix_dashboard"
                 # In both these cases, the issue opened will be "MP-1234"
+                # This is also checks if the prefix is in the name, and adds it if not, so:
+                # "MP-1234" opens the issue "MP-1234",
+                # "mp-1234" opens the issue "mp-1234",
+                # and "1234" opens the issue "MP-1234".
+# NOTE: since jira is case insensitive, the first two examples open the same issue
 jira ABC-123    # opens an existing issue
 jira ABC-123 m  # opens an existing issue for adding a comment
 ```

+ 1 - 1
plugins/jira/jira.plugin.zsh

@@ -75,7 +75,7 @@ function jira() {
       # Strip suffixes starting with _
       issue_arg=(${(s:_:)issue_arg})
       issue_arg=${issue_arg[1]}
-      if [[ "$issue_arg" = ${jira_prefix}* ]]; then
+      if [[ "${issue_arg:l}" = ${jira_prefix:l}* ]]; then
         issue="${issue_arg}"
       else
         issue="${jira_prefix}${issue_arg}"