Browse Source

Some improvements

 - Adding documentation
 - Note the effect empty array
 - Fix spelling
 - Using new test `[[...]]`
LE Manh Cuong 8 years ago
parent
commit
5e77e00ad5
3 changed files with 13 additions and 4 deletions
  1. 8 0
      README.markdown
  2. 3 3
      oh-my-zsh.sh
  3. 2 1
      templates/zshrc.zsh-template

+ 8 - 0
README.markdown

@@ -88,6 +88,14 @@ If you're feeling feisty, you can let the computer select one randomly for you e
 ZSH_THEME="random" # (...please let it be pie... please be some pie..)
 ```
 
+And if you want to pick random theme from a list of your favorite themes:
+
+```shell
+ZSH_THEM_RANDOM_CANDIDATES=(
+  "robbyrussell"
+  "agnoster"
+)
+```
 
 ## Advanced Topics
 

+ 3 - 3
oh-my-zsh.sh

@@ -93,9 +93,9 @@ done
 unset config_file
 
 # Load the theme
-if [ "$ZSH_THEME" = "random" ]; then
-  if [ "${(t)ZSH_THEME_RANDOM_CANDICATES}" = "array" ] && [ "${#ZSH_THEME_RANDOM_CANDICATES[@]}" -gt 0 ]; then
-    themes=($ZSH/themes/${^ZSH_THEME_RANDOM_CANDICATES}.zsh-theme)
+if [[ "$ZSH_THEME" == "random" ]]; then
+  if [[ "${(t)ZSH_THEME_RANDOM_CANDIDATES}" = "array" ]] && [[ "${#ZSH_THEME_RANDOM_CANDIDATES[@]}" -gt 0 ]]; then
+    themes=($ZSH/themes/${^ZSH_THEME_RANDOM_CANDIDATES}.zsh-theme)
   else
     themes=($ZSH/themes/*zsh-theme)
   fi

+ 2 - 1
templates/zshrc.zsh-template

@@ -11,7 +11,8 @@ ZSH_THEME="robbyrussell"
 # Setting this variable when ZSH_THEME=random
 # cause zsh load theme from this variable instead of
 # looking in ~/.oh-my-zsh/themes/
-# ZSH_THEME_RANDOM_CANDICATES=()
+# An empty array have no effect
+# ZSH_THEME_RANDOM_CANDIDATES=( "robbyrussell" "agnoster" )
 
 # Uncomment the following line to use case-sensitive completion.
 # CASE_SENSITIVE="true"